[asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

[Jared Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14907
-----------------------------------------------------------



/branches/13/formats/format_wav.c
<https://reviewboard.asterisk.org/r/4544/#comment25527>

    Red blob...



/branches/13/formats/format_wav.c
<https://reviewboard.asterisk.org/r/4544/#comment25529>

    Red blob here...



/branches/13/formats/format_wav_gsm.c
<https://reviewboard.asterisk.org/r/4544/#comment25530>

    And here as well...


While most of my comments are about the coding standards, the meat of this patch is very straightforward, and shouldn't cause any problems.

- Jared Smith


On March 27, 2015, 12:02 p.m., Diederik de Groot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4544/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 12:02 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
>     https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs. clang compiler warning:-Wself-assign
> 
> 
> Diffs
> -----
> 
>   /branches/13/formats/format_wav_gsm.c 433444 
>   /branches/13/formats/format_wav.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150327/a61866c4/attachment-0001.html>