[asterisk-dev] [Code Review] 4525: clang compiler warning: -Wabsolute-value

[Diederik de Groot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4525/
-----------------------------------------------------------

(Updated March 27, 2015, 1:38 p.m.)


Review request for Asterisk Developers.


Changes
-------

Moved fake 'issues' to description instead


Bugs: ASTERISK-24917
    https://issues.asterisk.org/jira/browse/ASTERISK-24917


Repository: Asterisk


Description (updated)
-------

clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs

clang compiler warning:-Wabsolute-value

Changes:
/branches/13/apps/app_queue.c:3687 int -> long for avgholdmins, avgholdsecs;
/branches/13/apps/app_queue.c:6581 int -> long for holdtime, holdtimesecs;
/branches/13/channels/chan_iax2.c:6080 Moved "adjust" here, so it can help out in casting (ms - p->nextpred) to int
/branches/13/res/res_calendar.c:1109 Not sure if this is prefered over downcasting to int


Diffs
-----

  /branches/13/res/res_rtp_asterisk.c 433444 
  /branches/13/res/res_calendar.c 433444 
  /branches/13/main/jitterbuf.c 433444 
  /branches/13/channels/chan_iax2.c 433444 
  /branches/13/apps/app_queue.c 433444 

Diff: https://reviewboard.asterisk.org/r/4525/diff/


Testing
-------


Thanks,

Diederik de Groot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150327/029f3ace/attachment.html>