[asterisk-dev] [Code Review] 4539: clang compiler warning: -Winitializer-overrides

[Diederik de Groot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4539/
-----------------------------------------------------------

(Updated March 27, 2015, 12:41 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-24917
    https://issues.asterisk.org/jira/browse/ASTERISK-24917


Repository: Asterisk


Description (updated)
-------

clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs. 

clang compiler warning:-Winitializer-overrides

Issue:
res_pjsip/config_transport.c:382:25: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
        [PJSIP_TLSV1_METHOD] = "tlsv1",
res_pjsip/config_transport.c:380:31: note: previous initialization is here
        [PJSIP_SSL_DEFAULT_METHOD] = "default",

Possible Solutions:
1. PJSIP_SSL_DEFAULT_METHOD is defined as PJSIP_TLSV1_METHOD -> remove the offending initializer in line 380
2. define PJSIP_SSL_DEFAULT_METHOD locally (overriding the default define from /usr/include/pjsip/sip_transport_tls.h) and use a different value for it.

Not sure which method would be preferred, leaving that decision to the code owner.


Diffs
-----

  /branches/13/res/res_pjsip/config_transport.c 433444 

Diff: https://reviewboard.asterisk.org/r/4539/diff/


Testing
-------


Thanks,

Diederik de Groot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150327/a4d7fb14/attachment.html>