[asterisk-dev] [Code Review] 4535: clang compiler warning: -Wenum-conversion

[Diederik de Groot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4535/#review14868
-----------------------------------------------------------



/branches/13/channels/chan_pjsip.c
<https://reviewboard.asterisk.org/r/4535/#comment25491>

    Wrong enum being used



/branches/13/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/4535/#comment25494>

    Incorrect enum



/branches/13/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/4535/#comment25493>

    Incorrect enum returned



/branches/13/include/asterisk/strings.h
<https://reviewboard.asterisk.org/r/4535/#comment25495>

    Not 100% sure if this substition is correct. Please verify.



/branches/13/main/strings.c
<https://reviewboard.asterisk.org/r/4535/#comment25496>

    Not 100% sure if this substition is correct. Please verify.



/branches/13/res/res_stasis.c
<https://reviewboard.asterisk.org/r/4535/#comment25497>

    Incorrect enum for return value


- Diederik de Groot


On March 26, 2015, 11:55 p.m., Diederik de Groot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4535/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 11:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
>     https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs\nclang compiler warning:-Wenum-conversion
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_stasis.c 433444 
>   /branches/13/main/strings.c 433444 
>   /branches/13/include/asterisk/strings.h 433444 
>   /branches/13/channels/chan_sip.c 433444 
>   /branches/13/channels/chan_pjsip.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4535/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150326/a7684156/attachment.html>