[asterisk-dev] [Code Review] 4500: ast_register_atexit should only be used when absolutely needed (11 version)

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4500/
-----------------------------------------------------------

(Updated March 26, 2015, 5:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 433495


Bugs: ASTERISK-24142, ASTERISK-24683, ASTERISK-24805, and ASTERISK-24881
    https://issues.asterisk.org/jira/browse/ASTERISK-24142
    https://issues.asterisk.org/jira/browse/ASTERISK-24683
    https://issues.asterisk.org/jira/browse/ASTERISK-24805
    https://issues.asterisk.org/jira/browse/ASTERISK-24881


Repository: Asterisk


Description
-------

We've had many issues related to "core stop now" or "core restart now" causing segmentation faults.  The solution to this is to change almost everything to use ast_register_cleanup.

Exceptions:
CDR: Flush records.
res_musiconhold: Kill external applications.
AstDB: Close the DB.
canary_exit: Kill canary process.

Although some changes from ast_register_atexit to ast_register_cleanup are not strictly necessary, the point is for nothing to use ast_register_atexit except where required.  For this reason the change is across the board.


Diffs
-----

  /branches/11/main/xmldoc.c 432991 
  /branches/11/main/utils.c 432991 
  /branches/11/main/udptl.c 432991 
  /branches/11/main/translate.c 432991 
  /branches/11/main/timing.c 432991 
  /branches/11/main/threadstorage.c 432991 
  /branches/11/main/test.c 432991 
  /branches/11/main/taskprocessor.c 432991 
  /branches/11/main/stun.c 432991 
  /branches/11/main/pbx.c 432991 
  /branches/11/main/named_acl.c 432991 
  /branches/11/main/message.c 432991 
  /branches/11/main/manager.c 432991 
  /branches/11/main/indications.c 432991 
  /branches/11/main/image.c 432991 
  /branches/11/main/http.c 432991 
  /branches/11/main/format.c 432991 
  /branches/11/main/file.c 432991 
  /branches/11/main/features.c 432991 
  /branches/11/main/event.c 432991 
  /branches/11/main/dnsmgr.c 432991 
  /branches/11/main/data.c 432991 
  /branches/11/main/config.c 432991 
  /branches/11/main/cli.c 432991 
  /branches/11/main/channel.c 432991 
  /branches/11/main/cel.c 432991 
  /branches/11/main/ccss.c 432991 
  /branches/11/main/astobj2.c 432991 
  /branches/11/main/astmm.c 432991 
  /branches/11/main/astfd.c 432991 
  /branches/11/main/asterisk.c 432991 
  /branches/11/main/aoc.c 432991 
  /branches/11/include/asterisk.h 432991 

Diff: https://reviewboard.asterisk.org/r/4500/diff/


Testing
-------

Compiled, started and ran 'core stop now'.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150326/a2c060de/attachment.html>