[asterisk-dev] [Code Review] 4523: res_pjsip_registrar_expire.c: Cleanup scheduler leaks on unload/shutdown.

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4523/#review14844
-----------------------------------------------------------



/branches/13/res/res_pjsip_registrar_expire.c
<https://reviewboard.asterisk.org/r/4523/#comment25451>

    Is it possible for sched to be NULL on AST_SCHED_DEL_UNREF? I realize if sched is NULL contact_autoexpire *should* be empty, but I wonder if the ao2_callback should be placed under the "if (sched)" check just to be on the safe side.


- Kevin Harwell


On March 25, 2015, 11:01 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4523/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 11:01 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Contact expiration object refs were leaked when the module was unloaded.
> 
> * Made empty the scheduler of entries before destroying it to release the
> object ref held by the scheduler entry.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_registrar_expire.c 433388 
> 
> Diff: https://reviewboard.asterisk.org/r/4523/diff/
> 
> 
> Testing
> -------
> 
> Before the patch valgrind reported struct contact_expiration object memory leaks.
> After the patch valgrind no longer reports those leaks.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150326/52ac5e51/attachment.html>