[asterisk-dev] Change in repotools[master]: Update commit_msg.py output format.

[Matt Jordan (Code Review)]

Matt Jordan has posted comments on this change.

Change subject: Update commit_msg.py output format.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/6/5/commit_msg.py
File commit_msg.py:

Line 67:         attachments.append("    %s submitted by %s (license %d)" % (x['filename'], x['author']['name'], licenseid))
This particular change is fine (it is in line with the wiki). Unfortunately, we'll also need to update digium_commits.py, which is used to parse out the commit message to produce the release summaries included in the release tarballs.

In that script, we should probably look for both 'uploaded by' as well as 'submitted by', as it is used to look at historical commits as well.

We should probably go ahead and make the change in that module at the same time as this patch - otherwise, the two will get out of sync the next time we make releases.


-- 
To view, visit https://gerrit.asterisk.org/6
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3a7adf2ca0d1d38d625fc5ba6922b99fb37f7
Gerrit-PatchSet: 5
Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-HasComments: Yes