[asterisk-dev] Change in testsuite[master]: Add .gitignore files

[Corey Farrell (Code Review)]

Corey Farrell has posted comments on this change.

Change subject: Add .gitignore files
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

Looks pretty good to me.  Up to you if you want to address the comments I've made or just let it be for another review.

https://gerrit.asterisk.org/#/c/8/1/.gitignore
File .gitignore:

Line 3
While we're here can we add /astroot?  This is where ./run-local installs Asterisk.


https://gerrit.asterisk.org/#/c/8/1/asttest/self-tests/.gitignore
File asttest/self-tests/.gitignore:

Line 1: **/asttest.log
Nit-pick - just "asttest.log" should do.


https://gerrit.asterisk.org/#/c/8/1/logs/.gitignore
File logs/.gitignore:

Line 1: [^.]*
Personally I'd prefer that we instead add /logs to the root .gitignore, have runtests.py create the directory if not found during start-up.  This would resolve breakage caused by accidentally running:
rm -fr logs
Instead of:
rm -fr logs/*

It's up to you, if you want I can submit this as a separate change later since it will require a changes to code.


-- 
To view, visit https://gerrit.asterisk.org/8
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc56ac80bcb1981b66a6b514cf817f7423f6ec
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Russell Bryant <russell at russellbryant.net>
Gerrit-HasComments: Yes