[asterisk-dev] [Code Review] 4518: testsuite: Add PJSIP test for new rpid_immediate option.

[rmudgett]

> On March 24, 2015, 8:25 a.m., Joshua Colp wrote:
> > /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf, line 25
> > <https://reviewboard.asterisk.org/r/4518/diff/3/?file=72766#file72766line25>
> >
> >     Same for contacts when udp is wanted. The transport= isn't needed.

Sure.  This and the other transport lines were copy-pasted from another test.


> On March 24, 2015, 8:25 a.m., Joshua Colp wrote:
> > /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/extensions.conf, line 20
> > <https://reviewboard.asterisk.org/r/4518/diff/3/?file=72765#file72765line20>
> >
> >     With how slow the agents can be are we sure this is enough?

It better be long enough.  If it takes more than 2 seconds on a single Asterisk instance test to send out a message then those agents really are too slow.  Though it can always be increased if it turns out it isn't long enough.  I initially had 1 second for my test box but increased it to 2 for the slower agents.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4518/#review14790
-----------------------------------------------------------


On March 23, 2015, 4:55 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4518/
> -----------------------------------------------------------
> 
> (Updated March 23, 2015, 4:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24781
>     https://issues.asterisk.org/jira/browse/ASTERISK-24781
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Test the rpid_immediate option when enabled and disabled.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 6555 
>   /asterisk/trunk/tests/channels/pjsip/rpid_immediate/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4518/diff/
> 
> 
> Testing
> -------
> 
> This is the testsuite test to test the rpid_immediate option added by review:
> https://reviewboard.asterisk.org/r/4473/
> 
> The test passes.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150324/8d3fbe2b/attachment.html>