[asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

[Joshua Colp]

> On March 23, 2015, 9:45 p.m., Matt Jordan wrote:
> > ./branches/13/apps/app_stasis.c, lines 75-79
> > <https://reviewboard.asterisk.org/r/4519/diff/1/?file=72716#file72716line75>
> >
> >     You'll want to document this new channel variable in the XML documentation at the top of the file. Something like:
> >     
> >     			<para>This application will set the following channel variable upon completion:</para>
> >     			<variablelist>
> >     				<variable name="STASISSTATUS">
> >     					<para>This indicates the status of the execution of the Stasis application.</para>
> >     					<value name="SUCCESS" />
> >     					<value name="FAILED" />
> >     				</variable>
> >     			</variablelist>

You also need to clarify (like you did in the description) what success and failed mean. If I'm a user looking at this variable I'd like to know more about what "failed" means and when it can happen.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/#review14778
-----------------------------------------------------------


On March 23, 2015, 4:36 a.m., Ashley Sanders wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4519/
> -----------------------------------------------------------
> 
> (Updated March 23, 2015, 4:36 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24802
>     https://issues.asterisk.org/jira/browse/ASTERISK-24802
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When an error occurs while writing to a web socket, the web socket is disconnected and the event is logged. A side-effect of this, however, is that any application on the other side waiting for a response from Stasis is left hanging indefinitely (as there is no mechanism presently available for notifying interested parties about web socket error states in Stasis).
> 
> To remedy this scenario, this patch introduces a new channel variable: STASIS_STATUS.
> 
> The possible values for STASIS_STATUS are:
> INITIALIZING    - Indicates Stasis is starting
> ACTIVE          - The channel is active in Stasis
> SUCCESS         - The channel has exited Stasis without any failures
> FAILED          - Something caused Stasis to croak. Some (not all) possible reasons for this: 
>                     - The app registry is not instantiated; 
>                     - The app requested is not registered; 
>                     - The app requested is not active; 
>                     - Stasis couldn't send a start message
> 
>  ***Note*** This is just the patch to the Asterisk source. The testsuite review is coming soon to a reviewboard near you (well, this reviewboard.)
> https://reviewboard.asterisk.org/r/4520
> 
> 
> Diffs
> -----
> 
>   ./branches/13/res/res_stasis.c 433290 
>   ./branches/13/apps/app_stasis.c 433290 
> 
> Diff: https://reviewboard.asterisk.org/r/4519/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashley Sanders
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150324/29380c80/attachment.html>