[asterisk-dev] [Code Review] 4517: chan_pjsip: update connected line information required

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4517/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

The update_connected_line_information indication required the COLP configuration options to always be set to allow. Otherwise a 501 was issued. Refactored the code to only update the connected line info when appropriate and not block other messages if the endpoint wasn't configured to send pai or rpid info.


Diffs
-----

  branches/13/channels/chan_pjsip.c 433200 

Diff: https://reviewboard.asterisk.org/r/4517/diff/


Testing
-------

The testsuite test 'tests/channels/pjsip/transfers/blind_transfer/caller_refer_only' was failing due to this bug. Patched the code and the test now passes again. Also ran other pjsip testsuite tests for good measure.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150320/f38f3fcc/attachment-0001.html>