[asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

[gareth]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4391/
-----------------------------------------------------------

(Updated March 20, 2015, 2:34 a.m.)


Review request for Asterisk Developers.


Changes
-------

New Patch Behaviour:

Output from the CLI command is now sent to the client as a series of "Output:" headers.

malloc, lseek and read errors will now cause an error response to be sent to the client rather than sending no output.


Bugs: ASTERISK-24730
    https://issues.asterisk.org/jira/browse/ASTERISK-24730


Repository: Asterisk


Description
-------

This patch adds a blank line between the headers and the output in the Command action response. The reason for this change is to make it easier to determine where the headers end and the output from the command starts.

Currently, to parse a response to a Command action, one has to:

1. Read one line, if line is "Response: Error", parse the remaining as a standard AMI response and stop.
2. Read one more line - or two if you used an ActionID - those lines are the headers.
3. Then read everything up to "--END COMMAND--\r\n\r\n".

That could be changed to:

1. Read standard AMI response.
2. If "Response: Follows", then read everything up to "--END COMMAND--\r\n\r\n".

The AMI version has been increased to 2.8.0 as this is a protocol change and so that clients detect the new behavior.

Adding a blank line should not cause older parsers to fail as they have to read everything up to "--END COMMAND--\r\n\r\n" anyway.

Adding a blank line will also not cause the AMI to HTML/XML encoder to fail to separate the headers from the output as it checks for the presence of a ":" character, which a blank line does not contain.


Diffs (updated)
-----

  /trunk/main/manager.c 433198 
  /trunk/include/asterisk/manager.h 433198 
  /trunk/UPGRADE.txt 433198 

Diff: https://reviewboard.asterisk.org/r/4391/diff/


Testing
-------

Connected to manager, issued 'core show uptime' command and verified that there was a blank line between the headers and output.


Thanks,

gareth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150320/d91e8c97/attachment-0001.html>