[asterisk-dev] [Code Review] 4512: dns: Add res_resolver_unbound module with unit tests.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4512/#review14748
-----------------------------------------------------------

Ship it!


This gets a "ship it!" from me based on the resolver implementation. As the writer of the unit tests, though, I feel like getting approval from someone else would be a good plan.

- Mark Michelson


On March 19, 2015, 6:36 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4512/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 6:36 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24836
>     https://issues.asterisk.org/jira/browse/ASTERISK-24836
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds a res_resolver_unbound module which uses libunbound and implements the core DNS resolver API. Queries can be started and cancelled as expected. Configuration also exists to change the behavior of the resolver some. Unit tests are present which use the libunbound zone and data API to add local records and then confirm they can be queried and are as expected.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_resolver_unbound.c PRE-CREATION 
>   /trunk/makeopts.in 433107 
>   /trunk/configure.ac 433107 
>   /trunk/configs/samples/resolver_unbound.conf.sample PRE-CREATION 
>   /trunk/build_tools/menuselect-deps.in 433107 
> 
> Diff: https://reviewboard.asterisk.org/r/4512/diff/
> 
> 
> Testing
> -------
> 
> Hacked in a query to my own domain and confirmed it worked. Also ran the unit tests and confirmed they pass.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150319/5a73ab5d/attachment-0001.html>