[asterisk-dev] [Code Review] 4505: Asterisk 13 PJSIP sends RTP packets in wrong byte order on Intel platform when using slin codec

[Frankie Chin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4505/
-----------------------------------------------------------

(Updated March 17, 2015, 3:36 a.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-24858
    https://issues.asterisk.org/jira/browse/ASTERISK-24858


Repository: Asterisk


Description (updated)
-------

In Asterisk 13.2.0 when SLIN codec is used in two Asterisk servers registered to one another via PJSIP, the RTP payload is sent in the wrong byte order. The patch addresses the following based on the correct behavior in Asterisk 12.8.1:
1) Save ptime = 20 as the framing in the ast_rtp_codecs structure when creating outgoing SDP packet (res_pjsip_sdp_rtp.c)
2) Do not copy the framing when copying the payload (rtp_engine.c)
3) Introduce the new "smoother_be" flagin the ast_codec structure. Set this flag = 1 for all the SLIN codecs (codec_builtin.c).
4) Check for this "smoother_be" flag before using the smoother on the data (res_rtp_asterisk.c)


Diffs
-----

  /tags/13.2.0/res/res_rtp_asterisk.c 433002 
  /tags/13.2.0/res/res_pjsip_sdp_rtp.c 433002 
  /tags/13.2.0/main/rtp_engine.c 433002 
  /tags/13.2.0/main/format.c 433002 
  /tags/13.2.0/main/codec_builtin.c 433002 
  /tags/13.2.0/include/asterisk/format.h 433002 
  /tags/13.2.0/include/asterisk/codec.h 433002 

Diff: https://reviewboard.asterisk.org/r/4505/diff/


Testing
-------

The patch was tested using the scenario described in ASTERISK-24858


Thanks,

Frankie Chin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150317/65ef0d64/attachment-0001.html>