[asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/
-----------------------------------------------------------

(Updated March 16, 2015, 7:42 p.m.)


Review request for Asterisk Developers.


Changes
-------

Last update missed the __find_call file parameter fix.


Bugs: ASTERISK-24882
    https://issues.asterisk.org/jira/browse/ASTERISK-24882


Repository: Asterisk


Description
-------

This does have a minor change to sip_ref_peer and dialog_ref - the error messages about trying to reference a NULL is removed.  This message provided nothing useful.  The changes to sip_alloc / find_call make it easier to trace REF_DEBUG logs for leaked dialogs.

Note: I've posted the version of this patch for 13.  In trunk the 'struct ast_callid *' type has been replaced with a typedef 'ast_callid', effecting the parameter logger_callid of sip_alloc.


Diffs (updated)
-----

  /branches/13/channels/sip/include/sip.h 433002 
  /branches/13/channels/sip/include/dialog.h 433002 
  /branches/13/channels/chan_sip.c 433002 

Diff: https://reviewboard.asterisk.org/r/4189/diff/


Testing
-------

Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller of sip_alloc.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150316/bf8a2f10/attachment.html>