[asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/#review14712
-----------------------------------------------------------



/branches/13/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/4189/#comment25278>

    Is there a reason why char *file cannot be const?



/branches/13/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/4189/#comment25279>

    Is there a reason why char *file cannot be const?



/branches/13/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/4189/#comment25277>

    Take the assignment out of the if test.  The long assignment line has better line breaks outside of the if test.


- rmudgett


On March 15, 2015, 10 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4189/
> -----------------------------------------------------------
> 
> (Updated March 15, 2015, 10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24882
>     https://issues.asterisk.org/jira/browse/ASTERISK-24882
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This does have a minor change to sip_ref_peer and dialog_ref - the error messages about trying to reference a NULL is removed.  This message provided nothing useful.  The changes to sip_alloc / find_call make it easier to trace REF_DEBUG logs for leaked dialogs.
> 
> Note: I've posted the version of this patch for 13.  In trunk the 'struct ast_callid *' type has been replaced with a typedef 'ast_callid', effecting the parameter logger_callid of sip_alloc.
> 
> 
> Diffs
> -----
> 
>   /branches/13/channels/sip/include/sip.h 432806 
>   /branches/13/channels/sip/include/dialog.h 432806 
>   /branches/13/channels/chan_sip.c 432806 
> 
> Diff: https://reviewboard.asterisk.org/r/4189/diff/
> 
> 
> Testing
> -------
> 
> Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller of sip_alloc.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150316/2c647071/attachment.html>