[asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

Joshua Colp reviewboard at asterisk.org
Mon Mar 16 10:56:57 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
-----------------------------------------------------------

(Updated March 16, 2015, 3:56 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-24834
    https://issues.asterisk.org/jira/browse/ASTERISK-24834


Repository: Asterisk


Description
-------

This change implements the basic API as described on the DNS API wiki page. Minimal changes have been made as required based on real usage and getting a feel for it. As it is the core functionality is present. Resolvers can register, queries can be made (async / sync).

As the API was basically copy/pasted from the wiki page there still remain stubs to be filled in for higher level functionality (such as parsing and query sets).


Diffs (updated)
-----

  /trunk/main/dns_tlsa.c PRE-CREATION 
  /trunk/main/dns_srv.c PRE-CREATION 
  /trunk/main/dns_recurring.c PRE-CREATION 
  /trunk/main/dns_query_set.c PRE-CREATION 
  /trunk/main/dns_naptr.c PRE-CREATION 
  /trunk/main/dns_core.c PRE-CREATION 
  /trunk/include/asterisk/dns_tlsa.h PRE-CREATION 
  /trunk/include/asterisk/dns_srv.h PRE-CREATION 
  /trunk/include/asterisk/dns_resolver.h PRE-CREATION 
  /trunk/include/asterisk/dns_recurring.h PRE-CREATION 
  /trunk/include/asterisk/dns_query_set.h PRE-CREATION 
  /trunk/include/asterisk/dns_naptr.h PRE-CREATION 
  /trunk/include/asterisk/dns_internal.h PRE-CREATION 
  /trunk/include/asterisk/dns_core.h PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/4474/diff/


Testing
-------

Ran DNS unit tests as done by Mark, they are happy.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150316/873e68ba/attachment.html>


More information about the asterisk-dev mailing list