[asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/#review14701
-----------------------------------------------------------



/trunk/include/asterisk/dns_core.h
<https://reviewboard.asterisk.org/r/4474/#comment25260>

    Is an ast_dns_result guaranteed to be immutable as well?
    
    If so, it might be good to note that. If not, then there may be some locking additions that are necessary in the implementation.



/trunk/main/dns_core.c
<https://reviewboard.asterisk.org/r/4474/#comment25261>

    Does the ast_dns_result need to be an ao2 ref counted object?
    
    If so, why not just note that it is an ao2 object, and remove the ast_dns_result_free?



/trunk/main/dns_core.c
<https://reviewboard.asterisk.org/r/4474/#comment25262>

    I'd change these to WARNINGs, as they don't necessarily imply a (nearly) fatal problem.
    
    It may be worthwhile assert-ing on those that we would like to catch in the testsuite as well.



/trunk/main/dns_core.c
<https://reviewboard.asterisk.org/r/4474/#comment25263>

    Same finding here about asserts and WARNINGs.



/trunk/main/dns_recurring.c
<https://reviewboard.asterisk.org/r/4474/#comment25264>

    This could result in an explosion later if this is the last ref to hold recurring.


- Matt Jordan


On March 13, 2015, 11:04 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4474/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 11:04 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24834
>     https://issues.asterisk.org/jira/browse/ASTERISK-24834
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change implements the basic API as described on the DNS API wiki page. Minimal changes have been made as required based on real usage and getting a feel for it. As it is the core functionality is present. Resolvers can register, queries can be made (async / sync).
> 
> As the API was basically copy/pasted from the wiki page there still remain stubs to be filled in for higher level functionality (such as parsing and query sets).
> 
> 
> Diffs
> -----
> 
>   /trunk/main/dns_tlsa.c PRE-CREATION 
>   /trunk/main/dns_srv.c PRE-CREATION 
>   /trunk/main/dns_recurring.c PRE-CREATION 
>   /trunk/main/dns_query_set.c PRE-CREATION 
>   /trunk/main/dns_naptr.c PRE-CREATION 
>   /trunk/main/dns_core.c PRE-CREATION 
>   /trunk/include/asterisk/dns_tlsa.h PRE-CREATION 
>   /trunk/include/asterisk/dns_srv.h PRE-CREATION 
>   /trunk/include/asterisk/dns_resolver.h PRE-CREATION 
>   /trunk/include/asterisk/dns_recurring.h PRE-CREATION 
>   /trunk/include/asterisk/dns_query_set.h PRE-CREATION 
>   /trunk/include/asterisk/dns_naptr.h PRE-CREATION 
>   /trunk/include/asterisk/dns_internal.h PRE-CREATION 
>   /trunk/include/asterisk/dns_core.h PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4474/diff/
> 
> 
> Testing
> -------
> 
> Ran DNS unit tests as done by Mark, they are happy.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150316/27256edc/attachment-0001.html>