[asterisk-dev] [Code Review] 4471: Recurring asynchronous DNS query unit tests.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4471/#review14681
-----------------------------------------------------------

Ship it!


Besides the memory leak I accidentally gave you these look good to go.

- Joshua Colp


On March 10, 2015, 8:53 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4471/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 8:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> These are more unit tests for DNS, this time for recurring asynchronous queries. There are four tests here that test nominal and off-nominal recurring queries, as well as canceling recurring queries. Like with the core DNS unit tests, I do not have off-nominal cancellation tests because these would test the resolver rather than the DNS core.
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_dns_recurring.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4471/diff/
> 
> 
> Testing
> -------
> 
> These tests pass!
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150313/f527ca86/attachment.html>