[asterisk-dev] [Code Review] 4438: add auto-dtmf mode for pjsip

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4438/#review14667
-----------------------------------------------------------

Ship it!


My last few comments here are completely nit-picky stylistic things. Thanks for the contribution!

Currently, this will go into Asterisk trunk, as improvements to Asterisk that go into released branches need tests. If you're interested in writing tests, we can help point you in the right direction for it.

Regardless of the branch or trunk that this goes into, we'll need to update the CHANGES file accordingly with the new setting option.


/trunk/res/res_pjsip_sdp_rtp.c
<https://reviewboard.asterisk.org/r/4438/#comment25228>

    Another extraneous bit of white space :-)



/trunk/res/res_pjsip_sdp_rtp.c
<https://reviewboard.asterisk.org/r/4438/#comment25229>

    Double ';'



/trunk/res/res_pjsip_sdp_rtp.c
<https://reviewboard.asterisk.org/r/4438/#comment25230>

    Still a bit more extraneous white space



/trunk/res/res_pjsip_session.c
<https://reviewboard.asterisk.org/r/4438/#comment25231>

    I'd restore the blank line here, as it helps to separate setting up session object from the manipulation of the DSP features.


- Matt Jordan


On March 12, 2015, 2:52 a.m., yaron nahum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4438/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 2:52 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24706
>     https://issues.asterisk.org/jira/browse/ASTERISK-24706
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> add auto-dtmf mode for pjsip
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip_session.c 431537 
>   /trunk/res/res_pjsip_sdp_rtp.c 431537 
>   /trunk/res/res_pjsip/pjsip_configuration.c 431537 
>   /trunk/res/res_pjsip.c 431537 
>   /trunk/main/dsp.c 431537 
>   /trunk/include/asterisk/res_pjsip.h 431537 
>   /trunk/include/asterisk/dsp.h 431537 
>   /trunk/channels/chan_pjsip.c 431537 
> 
> Diff: https://reviewboard.asterisk.org/r/4438/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> yaron nahum
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150312/2acea32e/attachment.html>