[asterisk-dev] [Code Review] 4470: Testsuite: Generate UserEvent upon PJsua phones being ready.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4470/#review14666
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On March 11, 2015, 5:20 p.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4470/
> -----------------------------------------------------------
> 
> (Updated March 11, 2015, 5:20 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> The test that has been modified on this review would sometimes fail due to the PJsua phone not being ready to receive calls even though it had registered to Asterisk. The changes here resolve the issue by generating a UserEvent on all AMI connections when all PJsua phones are ready. Originating calls to the PJsua phones is now triggered by the 'PJsuaPhonesReady' UserEvent instead of the registration event.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml 6506 
>   /asterisk/trunk/sample-yaml/phones-config.yaml.sample PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/phones.py 6506 
> 
> Diff: https://reviewboard.asterisk.org/r/4470/diff/
> 
> 
> Testing
> -------
> 
> * Executed each test successfully 50+ times on local system and build agent where the test would sometimes fail.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150312/63779ea0/attachment.html>