[asterisk-dev] [Code Review] 4478: testsuite: Fix reference leaks and shutdown timeouts in more tests

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4478/#review14662
-----------------------------------------------------------

Ship it!


Regarding the remaining leak on the local optimize away test, if you do find that it is a leak in Asterisk, please file an issue for it.

- Mark Michelson


On March 12, 2015, 3:24 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4478/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 3:24 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> * apps/page/page_baseline: hangup channels ignoring errors
> * apps/queues/position_priority_maxlen: hangup channels
> * callparking_retrieval: hangup parkee
> * channels/SIP/sip_tls_call: hangup the channel that gives the last DTMF event
> * channels/local/local_optimize_away: no longer has shutdown timeout, but still has some reference leaks.  This might be an Asterisk leak.
> * rest_api/events/user/multi: requires chan_pjsip.  The missing of dependency was causing Bamboo failures.
> * rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app: delete the bridge
> * rest_api/request-bodies: delete the bridges
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/request-bodies/run-test 6522 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app/test-config.yaml 6522 
>   /asterisk/trunk/tests/rest_api/events/user/multi/test-config.yaml 6522 
>   /asterisk/trunk/tests/channels/local/local_optimize_away/test-config.yaml 6522 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/run-test 6522 
>   /asterisk/trunk/tests/callparking_retrieval/run-test 6522 
>   /asterisk/trunk/tests/apps/queues/position_priority_maxlen/run-test 6522 
>   /asterisk/trunk/tests/apps/page/page_baseline/run-test 6522 
> 
> Diff: https://reviewboard.asterisk.org/r/4478/diff/
> 
> 
> Testing
> -------
> 
> Of the modified tests only channels/local/local_optimize_away still fails for leaks.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150312/763e0303/attachment.html>