[asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

Scott Griepentrog reviewboard at asterisk.org
Tue Mar 10 10:27:42 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4468/
-----------------------------------------------------------

(Updated March 10, 2015, 10:27 a.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed review feedback.


Repository: Asterisk


Description
-------

Using the CHAOS random failure mechanism (https://reviewboard.asterisk.org/r/4463/) I uncovered several possibilities of a crash on null pointer, and one uninitialized variable that allowed ast_random to lock up if used before utils init.

Additionally, extra output to determine why Asterisk failed to initialize has been added.


Diffs (updated)
-----

  /branches/13/main/xmldoc.c 432661 
  /branches/13/main/utils.c 432661 
  /branches/13/main/manager.c 432661 
  /branches/13/main/endpoints.c 432661 
  /branches/13/main/config.c 432661 
  /branches/13/main/codec_builtin.c 432661 
  /branches/13/main/asterisk.c 432661 
  /branches/13/include/asterisk/config.h 432661 

Diff: https://reviewboard.asterisk.org/r/4468/diff/


Testing
-------


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150310/c32837f0/attachment-0001.html>


More information about the asterisk-dev mailing list