[asterisk-dev] [Code Review] 4469: core: Don't allocate snapshots with locks

rmudgett reviewboard at asterisk.org
Tue Mar 10 09:56:16 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4469/#review14627
-----------------------------------------------------------

Ship it!


Ship It!

- rmudgett


On March 10, 2015, 8:47 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4469/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 8:47 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Snapshots are immutable. They are created once and only read. Right now they are allocated with a lock. This is silly. This changes makes it so they aren't.
> 
> 
> Diffs
> -----
> 
>   /branches/13/main/stasis_channels.c 432666 
>   /branches/13/main/stasis_bridges.c 432666 
>   /branches/13/main/endpoints.c 432666 
> 
> Diff: https://reviewboard.asterisk.org/r/4469/diff/
> 
> 
> Testing
> -------
> 
> Did some basic scenarios and confirmed that stuff did not explode.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150310/327ca180/attachment.html>


More information about the asterisk-dev mailing list