[asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

[Joshua Colp]

> On March 9, 2015, 1:19 p.m., Corey Farrell wrote:
> > /branches/13/main/utils.c, line 614
> > <https://reviewboard.asterisk.org/r/4463/diff/2/?file=71877#file71877line614>
> >
> >     This looks like it should be applied to 11 as well.

I'd go so far as to say that bug fixes as a result of this should be a separate review.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4463/#review14613
-----------------------------------------------------------


On March 7, 2015, 6:01 a.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4463/
> -----------------------------------------------------------
> 
> (Updated March 7, 2015, 6:01 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Introduce chaotic (random) failures into certain critical operations to force improvements to error handling.
> 
> This patch introduces the DEBUG_CHAOS random failure mechanism and adds it to memory allocation wrappers in utils.h.  To be activated, DEBUG_CHAOS must be enabled in menuselect.
> 
> The failure rate (1 in X) is controlled by changing the define DEBUG_CHAOS_CHANCES_1IN in utils.h.
> 
> 
> Diffs
> -----
> 
>   /branches/13/main/xmldoc.c 432613 
>   /branches/13/main/utils.c 432613 
>   /branches/13/main/endpoints.c 432613 
>   /branches/13/main/config.c 432613 
>   /branches/13/main/codec_builtin.c 432613 
>   /branches/13/main/asterisk.c 432613 
>   /branches/13/include/asterisk/utils.h 432613 
>   /branches/13/build_tools/cflags.xml 432613 
> 
> Diff: https://reviewboard.asterisk.org/r/4463/diff/
> 
> 
> Testing
> -------
> 
> I'm unable to get Asterisk to actually start with 1 in 100,000 failure rate.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150309/7406f6f4/attachment.html>