[asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4463/
-----------------------------------------------------------

(Updated March 7, 2015, 12:01 a.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed several crashes on Asterisk startup.

Added diagnostic output on initialization failures.

Reworked CHAOS slightly to allow for use in other locations with different chance values.


Repository: Asterisk


Description
-------

Introduce chaotic (random) failures into certain critical operations to force improvements to error handling.

This patch introduces the DEBUG_CHAOS random failure mechanism and adds it to memory allocation wrappers in utils.h.  To be activated, DEBUG_CHAOS must be enabled in menuselect.

The failure rate (1 in X) is controlled by changing the define DEBUG_CHAOS_CHANCES_1IN in utils.h.


Diffs (updated)
-----

  /branches/13/main/xmldoc.c 432613 
  /branches/13/main/utils.c 432613 
  /branches/13/main/endpoints.c 432613 
  /branches/13/main/config.c 432613 
  /branches/13/main/codec_builtin.c 432613 
  /branches/13/main/asterisk.c 432613 
  /branches/13/include/asterisk/utils.h 432613 
  /branches/13/build_tools/cflags.xml 432613 

Diff: https://reviewboard.asterisk.org/r/4463/diff/


Testing
-------

I'm unable to get Asterisk to actually start with 1 in 100,000 failure rate.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150307/3eb1bf6c/attachment.html>