[asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

[rmudgett]

> On March 5, 2015, 2:24 p.m., Ashley Sanders wrote:
> > /branches/13/res/res_pjsip_refer.c, line 477
> > <https://reviewboard.asterisk.org/r/4460/diff/1/?file=71745#file71745line477>
> >
> >     For clarity, I suggest using a default case in the switch statement rather than representing the default value by an assignment outside of the switch statement.

Not using a default case here is intentional.  When a switch statement is used on an enum type, the compiler is configured to complain if the switch does not cover all enum values.  Adding a default case in the switch statement here causes all enum values to be handled including any future values that get added later.


> On March 5, 2015, 2:24 p.m., Ashley Sanders wrote:
> > /branches/13/res/res_pjsip_refer.c, line 808
> > <https://reviewboard.asterisk.org/r/4460/diff/1/?file=71745#file71745line808>
> >
> >     Here, also, is the same pattern I reported for the switch-statement bodies from lines 748 and 478. This could benefit from a common function for assigning the response value.

Much more refactoring is beyond the scope of the issue.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4460/#review14601
-----------------------------------------------------------


On March 4, 2015, 11:31 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4460/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 11:31 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24755
>     https://issues.asterisk.org/jira/browse/ASTERISK-24755
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A race condition happened between initiating a transfer and requesting
> that a dialog termination be delayed.  Occasionally, the transferrer
> channels would exit the bridge and hangup before the dialog termination
> was requested.
> 
> * Made request dialog termination delay before initiating the transfer
> action.  If the transfer fails then cancel the delayed dialog termination
> request.
> 
> * Made safely get the TRANSFER_CONTEXT channel value while the channel is
> locked in refer_incoming_attended_request() and
> refer_incoming_blind_request().  The pointer returned by
> pbx_builtin_getvar_helper() is only valid while the channel is locked.
> 
> * Made refer_attended_alloc() not create the ao2 object with an unneeded
> lock.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_session.exports.in 432446 
>   /branches/13/res/res_pjsip_session.c 432446 
>   /branches/13/res/res_pjsip_refer.c 432446 
>   /branches/13/include/asterisk/res_pjsip_session.h 432446 
> 
> Diff: https://reviewboard.asterisk.org/r/4460/diff/
> 
> 
> Testing
> -------
> 
> The testsuite tests/channels/pjsip/ tests still pass with the patch.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150306/8aeefe73/attachment.html>