[asterisk-dev] [Code Review] 4455: res_pjsip: conflicting endpoint identifiers

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4455/
-----------------------------------------------------------

(Updated March 5, 2015, 5:40 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed various feedback.


Bugs: ASTERISK-24840
    https://issues.asterisk.org/jira/browse/ASTERISK-24840


Repository: Asterisk


Description (updated)
-------

It's possible to have a scenario that will create a conflict between endpoint identifiers. For instance an incoming call could be identified by two different endpoint identifiers and the one chosen depended upon which identifier module loaded first. This of course causes problems when, for example, the incoming call is expected to be identified by username, but instead is identified by ip. This patch adds a new 'global' option to res_pjsip called 'endpoint_identifier_order'. It is a comma separated list of endpoint identifier names that specifies the order by which identifiers are processed and checked.


Diffs (updated)
-----

  branches/13/res/res_pjsip_endpoint_identifier_user.c 432482 
  branches/13/res/res_pjsip_endpoint_identifier_ip.c 432482 
  branches/13/res/res_pjsip_endpoint_identifier_anonymous.c 432482 
  branches/13/res/res_pjsip/config_global.c 432482 
  branches/13/res/res_pjsip.c 432482 
  branches/13/include/asterisk/res_pjsip.h 432482 
  branches/13/contrib/ast-db-manage/config/versions/45e3f47c6c44_add_pjsip_endpoint_identifier_order.py PRE-CREATION 
  branches/13/configs/samples/pjsip.conf.sample 432482 
  branches/13/CHANGES 432482 

Diff: https://reviewboard.asterisk.org/r/4455/diff/


Testing
-------

Added a testsuite test: https://reviewboard.asterisk.org/r/4456/


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150305/1e45e79f/attachment.html>