[asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4459/#review14592
-----------------------------------------------------------


You should compile in dev mode to catch all code warnings:
./configure --enable-dev-mode

Developer mode will not compile if there are any code warnings.  This would have caught the declarations within code.


http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/4459/#comment25142>

    Didn't get all the red blobs.



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/4459/#comment25143>

    guidelines: Declarations only at beginning of code blocks.


- rmudgett


On March 4, 2015, 2:20 p.m., Graham Barnett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4459/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 2:20 p.m.)
> 
> 
> Review request for Asterisk Developers and mattjordan.
> 
> 
> Bugs: ASTERISK-24786
>     https://issues.asterisk.org/jira/browse/ASTERISK-24786
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Asterisk terminates when playing a voicemail stored in LDAP
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c 432422 
> 
> Diff: https://reviewboard.asterisk.org/r/4459/diff/
> 
> 
> Testing
> -------
> 
> Tested against Microsoft Exchange 2007
> 
> 
> Thanks,
> 
> Graham Barnett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150304/6c5ddcb3/attachment.html>