[asterisk-dev] [Code Review] 4455: res_pjsip: conflicting endpoint identifiers

[Kevin Harwell]

> On March 3, 2015, 12:43 p.m., Joshua Colp wrote:
> > branches/13/CHANGES, line 31
> > <https://reviewboard.asterisk.org/r/4455/diff/1/?file=71719#file71719line31>
> >
> >     Pedantic: Not a fan of "identify_by_priority". How's about "endpoint_identifier_order"?

heh the last thing I did before posting this review was change the option name from 'identify_by_order' to 'identify_by_priority'. However, I think I like yours even better.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4455/#review14574
-----------------------------------------------------------


On March 2, 2015, 2:04 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4455/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 2:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24840
>     https://issues.asterisk.org/jira/browse/ASTERISK-24840
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> It's possible to have a scenario that will create a conflict between endpoint identifiers. For instance an incoming call could be identified by two different endpoint identifiers and the one chosen depended upon which identifier module loaded first. This of course causes problems when, for example, the incoming call is expected to be identified by username, but instead is identified by ip. This patch adds a new 'global' option to res_pjsip called 'identify_by_priority'. It is a comma separated list of endpoint identifier names that specifies the order by which identifiers are processed and checked.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip_endpoint_identifier_user.c 432422 
>   branches/13/res/res_pjsip_endpoint_identifier_ip.c 432422 
>   branches/13/res/res_pjsip_endpoint_identifier_anonymous.c 432422 
>   branches/13/res/res_pjsip/config_global.c 432422 
>   branches/13/res/res_pjsip.c 432422 
>   branches/13/include/asterisk/res_pjsip.h 432422 
>   branches/13/contrib/ast-db-manage/config/versions/45e3f47c6c44_add_pjsip_identify_by_priority.py PRE-CREATION 
>   branches/13/configs/samples/pjsip.conf.sample 432422 
>   branches/13/CHANGES 432422 
> 
> Diff: https://reviewboard.asterisk.org/r/4455/diff/
> 
> 
> Testing
> -------
> 
> Added a testsuite test: https://reviewboard.asterisk.org/r/4456/
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150304/29a70006/attachment.html>