[asterisk-dev] [Code Review] 4456: testsuite: res_pjsip - conflicting endpoint identifiers test

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4456/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-24840
    https://issues.asterisk.org/jira/browse/ASTERISK-24840


Repository: testsuite


Description
-------

It is possible that two or more endpoint identifiers could match against an incoming call. This test makes sure that no matter what order the endpoint identifier modules were loaded priority is given based on the ones specified in the global identify_by_priority option. See more details see https://reviewboard.asterisk.org/r/4455/


Diffs
-----

  /asterisk/trunk/tests/channels/pjsip/tests.yaml 6482 
  /asterisk/trunk/tests/channels/pjsip/endpoint_identify/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/endpoint_identify/configs/ast2/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/endpoint_identify/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/endpoint_identify/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/endpoint_identify/configs/ast1/extensions.conf PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/4456/diff/


Testing
-------

Ran the test without the code fix in and it would fail. Patched the code and it passed. Also modified the identify order and re-ran the test and it would fail as expected.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150302/e064f931/attachment.html>