[asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1
Paul Belanger
reviewboard at asterisk.org
Fri Jan 30 13:51:49 CST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14401
-----------------------------------------------------------
In general I like what you are doing. Some concerns on how difficult it will be for people to setup phones and actually use these samples.
/branches/13/configs/examples/super_awesome_company/README
<https://reviewboard.asterisk.org/r/4379/#comment24897>
maybe shorten directory name to awesome, or sae?
Or, another option would be to use Acme, Inc.
/branches/13/configs/examples/super_awesome_company/asterisk.conf
<https://reviewboard.asterisk.org/r/4379/#comment24898>
My thoughts of this file is just to symbiotic link the current asterisk.conf file.
Since, you are'nt really doing anything here.
/branches/13/configs/examples/super_awesome_company/asterisk.conf
<https://reviewboard.asterisk.org/r/4379/#comment24899>
This seems to be dead code, as such just remove?
/branches/13/configs/examples/super_awesome_company/extensions.conf
<https://reviewboard.asterisk.org/r/4379/#comment24900>
While this is good practices, in the real world using MAC for actual extensions is bulky and complicated.
I would suggest using actually 101-115 as extension numbers but using mac for the authenticate portion of your sip.conf files.
/branches/13/configs/examples/super_awesome_company/extensions.conf
<https://reviewboard.asterisk.org/r/4379/#comment24901>
If changing to 101-115 extensions, this can be condensed.
exten => _[1]XX,hint,PJSIP/${EXTEN}
/branches/13/configs/examples/super_awesome_company/extensions.conf
<https://reviewboard.asterisk.org/r/4379/#comment24902>
I'd also prefer to see the first time always a naked NoOp()
exten => 8000,1,NoOp()
same => n,Verbose(1, "blah")
this way, when jumping into new contexts, you know you'll always hit a naked noop.
/branches/13/configs/examples/super_awesome_company/extensions.conf
<https://reviewboard.asterisk.org/r/4379/#comment24903>
using ._ is not recommend practices and will generate warnings in asterisk.
Change to _X.
/branches/13/configs/examples/super_awesome_company/extensions.conf
<https://reviewboard.asterisk.org/r/4379/#comment24904>
I disagree with this comments. Moving subroutines into there own contexts allow you to reuse code between applications. However, this example does not do this, it could be possible to create generate subroutines in asterisk samples to share across my examples.
/branches/13/configs/examples/super_awesome_company/extensions.conf
<https://reviewboard.asterisk.org/r/4379/#comment24905>
I prefer putting include statements at the top of the context.
Also, include =>
/branches/13/configs/examples/super_awesome_company/indications.conf
<https://reviewboard.asterisk.org/r/4379/#comment24906>
Again, this file seem to be the default. I'd rather see a symlink.
/branches/13/configs/examples/super_awesome_company/logger.conf
<https://reviewboard.asterisk.org/r/4379/#comment24907>
Seems to be the default file, rather see a symlink
/branches/13/configs/examples/super_awesome_company/pjsip.conf
<https://reviewboard.asterisk.org/r/4379/#comment24908>
Issue I see with this file, it is going to be very complicated for a new uses to program 16 character HEX into their SIP phones.
I'd prefer we make this some what simple for people to actually connect phones to and demo out.
- Paul Belanger
On Jan. 27, 2015, 7:15 p.m., rnewton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4379/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 7:15 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> One of things discussed at the last AstriDevCon was better documentation (for everything!), but in particular, we mentioned needing some example configurations that pertain to a real-world scenario. That is, as opposed to the current "sample" files which are sort of all over the place at this point.
>
> This patch proposes a basic and minimal configuration of Asterisk to satisfy the requirements for the first phase of Super Awesome Company's implementation of Asterisk.
>
> I will submit four separate patches for the first phase, so that we don't have to review the entire thing all at once. This review is for the first patch.
>
> Who is Super Awesome Company? See https://wiki.asterisk.org/wiki/display/AST/Super+Awesome+Company
>
> For the first patch, I am attempting to satisfy the below requirements. The patch does not include a new make target, as I believe Matt Jordan offered to handle that.
>
> SAC requires:
>
> * PJSIP connectivity for all employee desk phones.
> * The ability for employees to call one another inside of the office.
> * Voicemail boxes for each of the employees.
>
> "Basic" configuration
>
> We want SAC to have a clean system. That means:
>
> * No 'autoload' in modules.conf. Explicitly load a basic configuration. If SAC doesn't need the module, don't load it.
> * Every module loaded should have a configuration file that is appropriate for it. This includes all the 'core' things that need configuration.
>
> pjsip.conf
>
> * A PJSIP configuration for their desk phones. Assume every endpoint that is a phone has:
> * A voicemail mailbox that they can subscribe to
> * A hint for their device
> * Note that the PJSIP configuration should adhere to best practices. That means MAC addresses for device names, etc.
>
> extensions.conf
>
> * A safe dialplan for intra-company communication. This should be templated out so that it is trivial to add additional devices (use pattern matching/pattern matching hints, etc.)
> * Receiving a Busy/Unavailable should result in going to VoiceMail
> * A user should be able to dial something and get to their VoiceMailMain without having to enter in their extension number
> * Note that mapping of MAC address endpoints to extension numbers should be done in some fashion that is easily extensible.
>
> voicemail.conf
>
> * Set up mailboxes for every person in SAC. Assign 'default' pins. Create reasonable basic settings.
> * Do not set up e-mail or pager addresses.
>
>
> REVIEW?
>
> Please, if possible look at this from a few angles:
>
> * Use the configuration, configure a couple phones and call between them. Leave voicemails and retrieve them.
> * Have I created any security issues?
> * Is my dialplan easy to understand?
> * Could anything be done more efficiently without making it over-complicated?
> * Have I over-complicated anything?
> * Are there any critical settings I'm missing from any of the files?
>
> A couple, more specific questions:
>
> * We have sample configs in /configs/samples; what directory do we want these configurations in? (I used /configs/examples for now, but I don't really like it)
> * We have the make target "make samples" for the current samples; what do we want for these new configs?
>
>
> Diffs
> -----
>
> /branches/13/configs/examples/super_awesome_company/voicemail.conf PRE-CREATION
> /branches/13/configs/examples/super_awesome_company/pjsip.conf PRE-CREATION
> /branches/13/configs/examples/super_awesome_company/musiconhold.conf PRE-CREATION
> /branches/13/configs/examples/super_awesome_company/modules.conf PRE-CREATION
> /branches/13/configs/examples/super_awesome_company/logger.conf PRE-CREATION
> /branches/13/configs/examples/super_awesome_company/indications.conf PRE-CREATION
> /branches/13/configs/examples/super_awesome_company/extensions.conf PRE-CREATION
> /branches/13/configs/examples/super_awesome_company/asterisk.conf PRE-CREATION
> /branches/13/configs/examples/super_awesome_company/README PRE-CREATION
>
> Diff: https://reviewboard.asterisk.org/r/4379/diff/
>
>
> Testing
> -------
>
> Setup Asterisk with configuration, connected up three phones using the first three users. Made calls between them all, left voicemails and retrieved them with all users. Verified MWI working with all phones.
>
>
> Thanks,
>
> rnewton
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150130/397ff1c5/attachment-0001.html>
More information about the asterisk-dev
mailing list