[asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4383/#review14394
-----------------------------------------------------------


The dialplan Dial() app entry can conflict with existing dialplan in the same context.  I'm assuming that I won't enable the hint dialplan unless I mean to do it through the wizard, but there is no option to skip the addition of the Dial() app also.  I would recommend either a) dropping the Dial() app but keep the hint, b) requiring the app be specified in the config or it won't be added.  In either case, you need to clearly document the interaction between pjsip_wizard added dialplan and extensions.conf entries - what will asterisk do if it's put in both, and will reloading either module change which dialplan is executed?  Make sure to cover both the explicit extension conflict cases i.e. 200 vs 200 and the wildcard _2XX vs 200.

- Scott Griepentrog


On Jan. 27, 2015, 8:23 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4383/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 8:23 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Looking at the Super Awesome Company sample reminded me that creating hints is just plain gruntwork.  So you can now have the pjsip conifg wizard auto-create them for you.
> 
> Specifying 'hint_exten' in the wizard will create 'exten => <hint_exten>,hint/PJSIP/<wizard_id>' in whatever is specified for 'hint_context'.
> Specifying 'hint_application' in the wizard will create 'exten => <hint_exten>,1,<hint_application>' in whatever is specified for 'hint_context'.
> 
> The default for 'hint_context' is the endpoint's context.
> The default for 'hint_application' is 'Dial(${HINT})'.
> There's no default for 'hint_exten'.  If not specified, neither the hint itself nor the application will be created.
> 
> Some may think this is the slippery slope to users.conf but hints are a basic necessity for phones unlike voicemail, manager, etc that users.conf creates.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip_config_wizard.c 431242 
>   branches/13/configs/samples/pjsip_wizard.conf.sample 431242 
> 
> Diff: https://reviewboard.asterisk.org/r/4383/diff/
> 
> 
> Testing
> -------
> 
> Existing config_wizard testsuite tests pass.
> Additional testsuite tests in the works.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150130/b4cf0c04/attachment-0001.html>