[asterisk-dev] [Code Review] 4380: tcptls: Bad file descriptor error when reloading chan_sip

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4380/#review14321
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Jan. 27, 2015, 2:25 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4380/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 2:25 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24728
>     https://issues.asterisk.org/jira/browse/ASTERISK-24728
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While running through some scenarios using chan_sip and tcp a problem would occur that resulted in a flood of bad file descriptor messages on the cli:
> 
> tcptls.c:712 ast_tcptls_server_root: Accept failed: Bad file descriptor
> 
> The message is received because the underlying socket has been closed, so is valid. This is probably happening because unloading of chan_sip is not atomic. That however is outside the scope of this patch. This patch simply stops the logging of multiple occurrences of that message.
> 
> 
> Diffs
> -----
> 
>   branches/11/main/tcptls.c 431201 
> 
> Diff: https://reviewboard.asterisk.org/r/4380/diff/
> 
> 
> Testing
> -------
> 
> This issue was found while doing some testing. Ran those tests again to make sure that the messages no longer consumed the cli and only printed once.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150127/b524bae7/attachment.html>