[asterisk-dev] [Code Review] 4371: Update res_format_attr_opus & res_format_attr_silk to new media formats architecture

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4371/#review14307
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Jan. 26, 2015, 11:38 a.m., Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4371/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 11:38 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In r419044, we changed how formats were handled, but the return value of the format_parse_sdp_fmtp functions in res_format_attr_opus and res_format_attr_silk were not updated, causing calls to fail.  Ran into this when getting codec_opus working with Asterisk 13.
> 
> Once the return value was corrected, we were crashing in opus_getjoint because of NULL format attributes.  I've fixed this as well in this patch.  There may be a similar issue with SILK, but I don't have access to codec_silk for Asterisk 13 so I cannot test.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_format_attr_silk.c 431089 
>   /branches/13/res/res_format_attr_opus.c 431089 
> 
> Diff: https://reviewboard.asterisk.org/r/4371/diff/
> 
> 
> Testing
> -------
> 
> Ran a test call with codec_opus.
> 
> 
> Thanks,
> 
> Sean Bright
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150127/7e554bae/attachment.html>