[asterisk-dev] [Code Review] 4373: Manager Action ModuleLoad gives incorrect response when used to reload modules

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4373/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 2:16 p.m.)


Review request for Asterisk Developers and jbigelow.


Changes
-------

Switch to 13, address finding.

That moment when you start doing Asterisk work again and feel like Rip Van Winkle...


Repository: Asterisk


Description
-------

ModuleLoad actions give the wrong response when used to reload a module. On success, it will issue a 'no such module' error instead of a success response even though the module was reloaded successfully.


Diffs (updated)
-----

  /branches/13/main/manager.c 431112 

Diff: https://reviewboard.asterisk.org/r/4373/diff/


Testing
-------

Before Patch:

Action: ModuleLoad
LoadType: reload
Module: pbx_config.so

Response: Error
Message: No such module.

CLI output showed the module was actually reloaded successfully.

After Patch:

Action: ModuleLoad
LoadType: reload
Module: pbx_config.so

Response: Success
Message: Module reloaded.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150126/b600e431/attachment.html>