[asterisk-dev] [Code Review] 4368: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v11 version)

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4368/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 5:51 p.m.)


Review request for Asterisk Developers.


Summary (updated)
-----------------

app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v11 version)


Bugs: ASTERISK-24719
    https://issues.asterisk.org/jira/browse/ASTERISK-24719


Repository: Asterisk


Description
-------

Starting and stopping conference recording more than once causes the
recording channels to be leaked.  For v13 the channels also show up in the
CLI "core show channels" output.

* Reworked and simplified the recording channel code to use
ast_bridge_impart() instead of managing the recording thread in the
ConfBridge code.  The recording channel's ref handling easily falls into
place and other off nominal code paths get handled better as a result.


Diffs
-----

  /branches/11/apps/confbridge/include/confbridge.h 431048 
  /branches/11/apps/app_confbridge.c 431049 

Diff: https://reviewboard.asterisk.org/r/4368/diff/


Testing
-------

With the test:
The confbridge testsuite tests still pass.
Manual testing no longer has the recording channel ref leak.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150123/25f1da41/attachment.html>