[asterisk-dev] [Code Review] 4363: res_pjsip: make it unloadable (take 2)

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4363/#review14275
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Jan. 21, 2015, 4:30 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4363/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 4:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24485
>     https://issues.asterisk.org/jira/browse/ASTERISK-24485
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The res_pjsip module was previously unloadable. With this patch it can now be unloaded.
> 
> This patch is based off the original patch on the issue by Corey Farrell with a few modifications. Removed a few changes not required to make the module unloadable and also fixed a bug that would cause asterisk to crash on unloading.
> 
> The first patch (found here: https://reviewboard.asterisk.org/r/4311/) had to be reverted due to a race condition it introduced on shutdown. It turned out that the following change to stasis_message_router was the cause (~line 258):
> 
> router->subscription = stasis_unsubscribe(router->subscription);
> 
> The patch found here is the original patch plus the fix for the problem (added locking).
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip/pjsip_outbound_auth.c 430884 
>   branches/13/res/res_pjsip/pjsip_options.c 430884 
>   branches/13/res/res_pjsip/pjsip_global_headers.c 430884 
>   branches/13/res/res_pjsip/pjsip_distributor.c 430884 
>   branches/13/res/res_pjsip/pjsip_configuration.c 430884 
>   branches/13/res/res_pjsip/location.c 430884 
>   branches/13/res/res_pjsip/include/res_pjsip_private.h 430884 
>   branches/13/res/res_pjsip/config_transport.c 430884 
>   branches/13/res/res_pjsip/config_auth.c 430884 
>   branches/13/res/res_pjsip.c 430884 
>   branches/13/main/stasis_message_router.c 430884 
> 
> Diff: https://reviewboard.asterisk.org/r/4363/diff/
> 
> 
> Testing
> -------
> 
> Ran the relevant unit and testsuite tests on two different machines since original patch passed on one.  Also verified that the module could unload and shutdown properly without any extra dependencies.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150123/4a9fb5a3/attachment-0001.html>