[asterisk-dev] [Code Review] 4354: Bridge core: Pass a ref with the swap channel when joining a bridge.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4354/
-----------------------------------------------------------

(Updated Jan. 20, 2015, 1:06 p.m.)


Review request for Asterisk Developers.


Changes
-------

Added and updated comments to try to make it clearer.


Bugs: ASTERISK-24649
    https://issues.asterisk.org/jira/browse/ASTERISK-24649


Repository: Asterisk


Description
-------

When code imparts a channel into a bridge to swap with another channel, a ref needs to be held on the swap channel to ensure that it cannot dissapear before finding it in the bridge.

* The ast_bridge_join() swap channel parameter now always steals a ref for the swap channel.  This is the only change to the bridge framework's public API semantics.

* bridge_channel_internal_join() now requires the bridge_channel->swap channel to pass in a ref.


Diffs (updated)
-----

  /branches/13/main/bridge_channel.c 430836 
  /branches/13/main/bridge.c 430836 
  /branches/13/include/asterisk/bridge_internal.h 430836 
  /branches/13/include/asterisk/bridge_channel_internal.h 430836 
  /branches/13/include/asterisk/bridge.h 430836 

Diff: https://reviewboard.asterisk.org/r/4354/diff/


Testing
-------

The testsutite masquerade super test and the --tags=transfer tests still pass.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150120/e38ce1d4/attachment.html>