[asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4347/#review14228
-----------------------------------------------------------



branches/13/res/parking/parking_applications.c
<https://reviewboard.asterisk.org/r/4347/#comment24688>

    Was there a problem with this already holding a retriever snapshot?  Otherwise this should just be an ast_assert() for paranoia's sake since it should always be NULL at this point.



branches/13/res/res_stasis.c
<https://reviewboard.asterisk.org/r/4347/#comment24687>

    1) The Doxygen for this function needs to be updated for all of the parameters.
    
    2) The only caller of this function in res/ari/resource_events.c has a code path that leaks the json_variables parameter.
    
    3) After calling this function, the caller needs to unref the jason_variables.  Either that or the semantics of this function needs to change so that the ref is passed to this function.


- rmudgett


On Jan. 15, 2015, 1:15 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4347/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 1:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24693
>     https://issues.asterisk.org/jira/browse/ASTERISK-24693
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch fixes a few memory leaks that were found in Asterisk.
> 
> 
> Diffs
> -----
> 
>   branches/13/rest-api-templates/param_parsing.mustache 430684 
>   branches/13/res/res_stasis.c 430684 
>   branches/13/res/res_pjsip_pubsub.c 430684 
>   branches/13/res/res_pjsip_mwi.c 430684 
>   branches/13/res/res_pjsip/pjsip_global_headers.c 430684 
>   branches/13/res/res_ari_events.c 430684 
>   branches/13/res/res_ari_endpoints.c 430684 
>   branches/13/res/res_ari_channels.c 430684 
>   branches/13/res/parking/parking_applications.c 430684 
>   branches/13/channels/chan_iax2.c 430684 
> 
> Diff: https://reviewboard.asterisk.org/r/4347/diff/
> 
> 
> Testing
> -------
> 
> Some manual testing done along with inspection of log files and malloc_debug data.  Also ran relevant unit and testsuite tests.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150119/5e4b2023/attachment.html>