[asterisk-dev] [Code Review] 4330: Testsuite: Add external bridging tests for Stasis bridge (one channel) interactions

[Matt Jordan]

> On Jan. 14, 2015, 4:45 p.m., opticron wrote:
> > /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/tests.yaml, line 2
> > <https://reviewboard.asterisk.org/r/4330/diff/1/?file=70508#file70508line2>
> >
> >     The files for this test seem to be missing.
> 
> jbigelow wrote:
>     They are but for whatever reason not shown here on reviewboard.
>     
>     # svn status -v tests/rest_api/external_interaction/ami_bridge/stasis_bridge/
>                   6226     6047 kmoore       tests/rest_api/external_interaction/ami_bridge/stasis_bridge
>     A                0       ?   ?           tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app
>     A  +             -       ?   ?           tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app/test-config.yaml
>     A  +             -     6047 kmoore       tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app/configs
>        +             -     6047 kmoore       tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app/configs/ast1
>        +             -     6047 kmoore       tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app/configs/ast1/extensions.conf
>     D             6226     6047 kmoore       tests/rest_api/external_interaction/ami_bridge/stasis_bridge/test-config.yaml
>     D             6226     6047 kmoore       tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs
>     D             6226     6047 kmoore       tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1
>     D             6226     6047 kmoore       tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf

Since these are just a rename, that shouldn't hold up the review of the new code in this patch.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4330/#review14188
-----------------------------------------------------------


On Jan. 12, 2015, 5:52 p.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4330/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 5:52 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Mark Michelson.
> 
> 
> Bugs: ASTERISK-24610
>     https://issues.asterisk.org/jira/browse/ASTERISK-24610
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds the remaining external bridging tests for Stasis bridge (one channel) interactions as defined on the StasisStart/StasisEnd Test Plan (tests 2.2, 2.3, and 2.4) at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826#StasisStart/StasisEndTestplan-ExternalBridging
> 
> This also renames the test 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/' to 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app' and adds these new tests under 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/'.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/tests.yaml 6226 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/test-config.yaml 6226 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/same_stasis_app/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/same_stasis_app/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_bridge/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/different_stasis_app/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/different_stasis_app/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf 6226 
> 
> Diff: https://reviewboard.asterisk.org/r/4330/diff/
> 
> 
> Testing
> -------
> 
> * Executed each test in a loop of 100 iterations with no failures.
> * Reviewed logs to ensure the tests were executing as expected.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150116/8872eda5/attachment.html>