[asterisk-dev] [Code Review] 4344: Add capath support to res_pjsip (new version of /r/4230)

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4344/
-----------------------------------------------------------

(Updated Jan. 15, 2015, 3:45 p.m.)


Review request for Asterisk Developers.


Changes
-------

Removed extra debug message used during tests.


Bugs: ASTERISK-24575
    https://issues.asterisk.org/jira/browse/ASTERISK-24575


Repository: Asterisk


Description
-------

I cannot publish on reviews that I did not open, so instead of updating /r/4230 with a new diff, I have created this new version of the review.

The PJProject patch has already been merged in revision 4973 of PJProject (http://trac.pjsip.org/repos/changeset/4973).

The patch presented here is pretty much exactly the same as the one that cloos made on /r/4230, with the following differences:
* There is an entry in CHANGES
* Since the PJProject change that went in resulted in a new function being added, a configure script change was made to be sure the new function exists. If it does not, then a warning is written to the console if a ca_path is specified in your pjsip.conf file.
* Documentation states that PJProject 2.4 is required to use the new ca_list_path option. This is based on my educated guess that the next version of PJProject will be 2.4 and not some other number. Is there a better way to express an unreleased version of PJProject?


Diffs (updated)
-----

  /branches/13/res/res_pjsip/config_transport.c 430625 
  /branches/13/res/res_pjsip.c 430625 
  /branches/13/include/asterisk/res_pjsip.h 430625 
  /branches/13/include/asterisk/autoconfig.h.in 430625 
  /branches/13/configure.ac 430625 
  /branches/13/configure UNKNOWN 
  /branches/13/configs/samples/pjsip.conf.sample 430625 
  /branches/13/CHANGES 430625 

Diff: https://reviewboard.asterisk.org/r/4344/diff/


Testing
-------

Ensured that the configure check worked as expected. Ensured that the configured ca_list_path is passed down to pjlib as expected.


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150115/236463db/attachment-0001.html>