[asterisk-dev] [Code Review] 3707: asterisk.pc file contains a spacing error in CFlags

Matt Jordan reviewboard at asterisk.org
Tue Jan 13 09:50:31 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3707/#review14169
-----------------------------------------------------------

Ship it!


Tested and verified that the patch properly formats the options mentioned in a generated asterisk.pc file.

Barring any further comment, this looks good.

- Matt Jordan


On July 3, 2014, 8:24 a.m., Diederik de Groot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3707/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 8:24 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23991
>     https://issues.asterisk.org/jira/browse/ASTERISK-23991
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> ASTERISK-23991
> 
> After installation the asterisk.pc file contains:
> Cflags: -I/usr/include/libxml2-g3
> 
> Which should have been:
> Cflags: -I/usr/include/libxml2 -g3
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/mkpkgconfig 417800 
> 
> Diff: https://reviewboard.asterisk.org/r/3707/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150113/10ef3d8a/attachment-0001.html>


More information about the asterisk-dev mailing list