[asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4328/#review14166
-----------------------------------------------------------


* "The transport type from above is used to determine which SRV record to look up. This means that the original URI *must* include the transport type for TCP and TLS types."
What if the URI is a SIPS URI? Does that have any bearing on transport selection?

* "The first configured transport matching the transport type and address family is selected"
What does this mean? Can a user influence which transport is "first" ?

* I really can't make sense of the "Multi-homed Transport Selection" section. Specifically, what is meant by "Source matches source in message" ?

* In the "connection-less protocol with maddr" section, what does "transport type" refer to? I assume it's a ;transport parameter from a URI, but which URI? Same goes for the "connection-less protocol without rport" section.

* "Configure a transport for each interface. The default transport will be the first one you choose."
I don't understand that second sentence. Does that mean the first transport in the configuration file is the default transport?

* Some "why" statements regarding the strategies for IPv4 and IPv6 would be useful. Why shouldn't an IPv6 wildcard be used, for instance?

- Mark Michelson


On Jan. 12, 2015, 1:33 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4328/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 1:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The transport selection process of PJSIP (and by extension some of our own logic) can be a dark dark thing. To help illuminate what happens I have created a wiki page[1] which goes through (based on the message type) the process by which a transport is chosen and how it can potentially change.
> 
> Stuff to look at:
> 1. Is this detailed enough?
> 2. Can you follow it? If not, how could it be made clearer?
> 3. Are there additional common issues that should be covered?
> 
> [1] https://wiki.asterisk.org/wiki/display/~jcolp/Transport+Selection
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviewboard.asterisk.org/r/4328/diff/
> 
> 
> Testing
> -------
> 
> I opened the wiki page. It opened.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150112/fed15065/attachment.html>