[asterisk-dev] [Code Review] 4320: res_fax: Make T.38 negotiation timeout configurable and handle T.38 switch failure

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4320/#review14128
-----------------------------------------------------------

Ship it!


Since you're adding an option, this should be noted in CHANGES.

- Mark Michelson


On Jan. 8, 2015, 1:25 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4320/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 1:25 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change makes the T.38 negotiation timeout configurable via res_fax.conf or the FAXOPT() dialplan function. It was previously hard coded to be 5 seconds.
> 
> This change also handles T.38 switch failures by aborting the fax since in the case where this can happen, both sides have agreed to switch to T.38 and Asterisk is unable to do so.
> 
> 
> Diffs
> -----
> 
>   branches/11/res/res_fax.c 430372 
>   branches/11/include/asterisk/res_fax.h 430372 
>   branches/11/configs/res_fax.conf.sample 430372 
> 
> Diff: https://reviewboard.asterisk.org/r/4320/diff/
> 
> 
> Testing
> -------
> 
> Manual testing and the test in review 4321.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150108/04f8282d/attachment.html>