[asterisk-dev] [Code Review] 4320: res_fax: Make T.38 negotiation timeout configurable and handle T.38 switch failure

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4320/#review14119
-----------------------------------------------------------



branches/11/include/asterisk/res_fax.h
<https://reviewboard.asterisk.org/r/4320/#comment24618>

    Does this need to be a public function?



branches/11/res/res_fax.c
<https://reviewboard.asterisk.org/r/4320/#comment24616>

    Add R/W to the beginning of the description like the others.



branches/11/res/res_fax.c
<https://reviewboard.asterisk.org/r/4320/#comment24615>

    Put a blank line between variable declarations and code to make it easier to find the declarations.



branches/11/res/res_fax.c
<https://reviewboard.asterisk.org/r/4320/#comment24614>

    Put a blank line between variable declarations and code to make it easier to find the declarations.



branches/11/res/res_fax.c
<https://reviewboard.asterisk.org/r/4320/#comment24617>

    This block looks like it could be put into a helper function and called by set_config() and here.



branches/11/res/res_fax.c
<https://reviewboard.asterisk.org/r/4320/#comment24613>

    Put a blank line between variable declarations and code to make it easier to find the declarations.


- rmudgett


On Jan. 7, 2015, 3:20 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4320/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 3:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change makes the T.38 negotiation timeout configurable via res_fax.conf or the FAXOPT() dialplan function. It was previously hard coded to be 5 seconds.
> 
> This change also handles T.38 switch failures by aborting the fax since in the case where this can happen, both sides have agreed to switch to T.38 and Asterisk is unable to do so.
> 
> 
> Diffs
> -----
> 
>   branches/11/res/res_fax.c 430338 
>   branches/11/include/asterisk/res_fax.h 430338 
>   branches/11/configs/res_fax.conf.sample 430338 
> 
> Diff: https://reviewboard.asterisk.org/r/4320/diff/
> 
> 
> Testing
> -------
> 
> Manual testing and the test in review 4321.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150107/1cefca4d/attachment-0001.html>