[asterisk-dev] [Code Review] 4319: testsuite: app_macro tests for channel redirect while the macro is active.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4319/#review14117
-----------------------------------------------------------



/asterisk/trunk/tests/apps/macro/redirect_inside/test-config.yaml
<https://reviewboard.asterisk.org/r/4319/#comment24612>

    I have a suggestion for preventing this from happening. Rather than using a UserEvent to indicate that you're in the macro and able to perform the redirect, trigger the redirect when you get a NewExten AMI event that says you're in context macro-redirect-me, extension s, and running application Echo.
    
    This way, your test has only a single UserEvent, which indicates that the channel was redirected to the expected location and that the test has concluded.
    
    You can use this same strategy in redirect_outside.


- Mark Michelson


On Jan. 7, 2015, 6:58 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4319/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 6:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23850
>     https://issues.asterisk.org/jira/browse/ASTERISK-23850
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Test channel redirect when a macro is active.
> 1) Redirect while in an active macro to an external dialplan location.
> 2) Redirect while in an active macro to an extension in the macro context.
> 3) Park while in an active macro and timeout to an external dialplan location.
> 4) Park while in an active macro and timeout to an extension in the macro context.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/tests.yaml 6185 
>   /asterisk/trunk/tests/apps/macro/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/redirect_outside/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/redirect_outside/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/redirect_inside/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/redirect_inside/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/park_timeout_outside/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/park_timeout_outside/configs/ast1/res_parking.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/park_timeout_outside/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/park_timeout_inside/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/park_timeout_inside/configs/ast1/res_parking.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/macro/park_timeout_inside/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4319/diff/
> 
> 
> Testing
> -------
> 
> All tests pass when the patch on review https://reviewboard.asterisk.org/r/4292/ is applied.
> Tests 2 and 4 fail when the patch is not applied.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150107/6dfb0866/attachment-0001.html>