[asterisk-dev] [Code Review] 4315: AMI: Make AMI actions that generate event lists consistent.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4315/
-----------------------------------------------------------

(Updated Jan. 7, 2015, 1:36 p.m.)


Review request for Asterisk Developers.


Changes
-------

Added note to CHANGES and UPGRADE.txt for AMI version bump.


Bugs: ASTERISK-24049
    https://issues.asterisk.org/jira/browse/ASTERISK-24049


Repository: Asterisk


Description
-------

* Made the following AMI actions use list API calls for consistency:
Agents
BridgeInfo
BridgeList
BridgeTechnologyList
ConfbridgeLIst
ConfbridgeLIstRooms
CoreShowChannels
DAHDIShowChannels
DBGet
DeviceStateList
ExtensionStateList
FAXSessions
Hangup
IAXpeerlist
IAXpeers
IAXregistry
MeetmeList
MeetmeListRooms
MWIGet
ParkedCalls
Parkinglots
PJSIPShowEndpoint
PJSIPShowEndpoints
PJSIPShowRegistrationsInbound
PJSIPShowRegistrationsOutbound
PJSIPShowResourceLists
PJSIPShowSubscriptionsInbound
PJSIPShowSubscriptionsOutbound
PresenceStateList
PRIShowSpans
QueueStatus
QueueSummary
ShowDialPlan
SIPpeers
SIPpeerstatus
SIPshowregistry
SKINNYdevices
SKINNYlines
Status
VoicemailUsersList

* Incremented the AMI version to 2.7.0.

* Changed astman_send_listack() to not use the listflag parameter and
always set the value to "Start" so the start capitalization is consistent.
i.e., The FAXSessions used "Start" while the rest of the system used
"start".  The corresponding complete event always used "Complete".

* Fixed ami_show_resource_lists() "PJSIPShowResourceLists" to output the
AMI ActionID for all of its list events.

* Fixed off-nominal AMI protocol error in manager_bridge_info(),
manager_parking_status_single_lot(), and
manager_parking_status_all_lots().  Use of astman_send_error() after
responding to the original AMI action request violates the action response
pattern by sending two responses.

* Fixed minor protocol error in action_getconfig() when no requested
categories are found.  Each line needs to be formatted as "Header: text".

* Fixed off-nominal memory leak in manager_build_parked_call_string().

* Eliminated unnecessary use of RAII_VAR() in ami_subscription_detail().


Diffs (updated)
-----

  /branches/13/res/res_pjsip_registrar.c 430354 
  /branches/13/res/res_pjsip_pubsub.c 430354 
  /branches/13/res/res_pjsip_outbound_registration.c 430354 
  /branches/13/res/res_pjsip/pjsip_configuration.c 430354 
  /branches/13/res/res_mwi_external_ami.c 430354 
  /branches/13/res/res_manager_presencestate.c 430354 
  /branches/13/res/res_manager_devicestate.c 430354 
  /branches/13/res/res_fax.c 430354 
  /branches/13/res/parking/parking_manager.c 430354 
  /branches/13/main/pbx.c 430354 
  /branches/13/main/manager_bridges.c 430354 
  /branches/13/main/manager.c 430354 
  /branches/13/main/db.c 430354 
  /branches/13/main/bridge.c 430354 
  /branches/13/include/asterisk/manager.h 430354 
  /branches/13/channels/chan_skinny.c 430354 
  /branches/13/channels/chan_sip.c 430354 
  /branches/13/channels/chan_iax2.c 430354 
  /branches/13/channels/chan_dahdi.c 430354 
  /branches/13/apps/app_voicemail.c 430354 
  /branches/13/apps/app_queue.c 430354 
  /branches/13/apps/app_meetme.c 430354 
  /branches/13/apps/app_confbridge.c 430354 
  /branches/13/apps/app_agent_pool.c 430354 
  /branches/13/UPGRADE.txt 430354 
  /branches/13/CHANGES 430354 

Diff: https://reviewboard.asterisk.org/r/4315/diff/


Testing
-------

Issued all of the AMI actions listed above to verify that the output was consistent.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150107/1f092ae9/attachment.html>