[asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

[George Joseph]

> On Jan. 7, 2015, 10:22 a.m., Joshua Colp wrote:
> > branches/13/res/res_pjsip_outbound_registration.c, lines 1501-1502
> > <https://reviewboard.asterisk.org/r/4304/diff/3/?file=70231#file70231line1501>
> >
> >     Did you test this? It was a "should be fine" statement.

I did.  An auth-only change got picked up immediately.  Since there was actually no change to the registration object there was no need to call the apply.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4304/#review14110
-----------------------------------------------------------


On Jan. 7, 2015, 8:52 a.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4304/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 8:52 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There are 2 issues with reloading registrations...
> 
> 1.  The 'can_reuse_registration' test wasn't considering the intervals or expiration in its determination of whether a registration changed or not so if you changed any of the intervals or the expiration and reloaded, the object would get reloaded but the actual timers wouldn't change.  can_reuse_registration now does a sorcery diff on the old and new objects instead of discretely testing certain fields.  Now if you change expiration for instance, and reload, the timer is updated and re-registration will occur on the new value.
> 
> 2.  If you mung up your password on an outbound registration you get a permanent failure.  If you fix the password (on the outbound_auth object) and reload, nothing tells outbound_registration to try again because the registration itself didn't change.  This patch adds an observer on the "auth" object type and if any auth changes, existing registration states are searched and those in a REJECTED_PERMANENT state are retried.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip_outbound_registration.c 430293 
> 
> Diff: https://reviewboard.asterisk.org/r/4304/diff/
> 
> 
> Testing
> -------
> 
> Tested locally with various scenarios using Wireshark to make sure intervals have changed and that auths are being retried.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150107/567bc8f6/attachment-0001.html>