[asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4304/#review14102
-----------------------------------------------------------



branches/13/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/4304/#comment24599>

    Explain why in these debug messages.



branches/13/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/4304/#comment24600>

    Applying configuration to outbound registration '%s'



branches/13/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/4304/#comment24601>

    No change between old configuration and new configuration on outbound registration '%s'. Using previous state.



branches/13/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/4304/#comment24603>

    Auths updated. Checking for any outbound registrations that are in permanent rejected state so they can be retried.



branches/13/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/4304/#comment24604>

    Trying outbound registration '%s' again



branches/13/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/4304/#comment24602>

    Calling sip_outbound_registration_apply here is overkill. 
    
    You should only need to push a sip_outbound_registration_perform task using the existing state.


- Joshua Colp


On Dec. 31, 2014, 1:41 a.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4304/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 1:41 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There are 2 issues with reloading registrations...
> 
> 1.  The 'can_reuse_registration' test wasn't considering the intervals or expiration in its determination of whether a registration changed or not so if you changed any of the intervals or the expiration and reloaded, the object would get reloaded but the actual timers wouldn't change.  can_reuse_registration now does a sorcery diff on the old and new objects instead of discretely testing certain fields.  Now if you change expiration for instance, and reload, the timer is updated and re-registration will occur on the new value.
> 
> 2.  If you mung up your password on an outbound registration you get a permanent failure.  If you fix the password (on the outbound_auth object) and reload, nothing tells outbound_registration to try again because the registration itself didn't change.  This patch adds an observer on the "auth" object type and if any auth changes, existing registration states are searched and those in a REJECTED_PERMANENT state are retried.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip_outbound_registration.c 430163 
> 
> Diff: https://reviewboard.asterisk.org/r/4304/diff/
> 
> 
> Testing
> -------
> 
> Tested locally with various scenarios using Wireshark to make sure intervals have changed and that auths are being retried.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150107/1c520fe1/attachment-0001.html>